-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Don't use LLVM libraries #158623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Don't use LLVM libraries #158623
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158623
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 1 Cancelled Job, 15 PendingAs of commit cfa4291 with merge base 0d40ff3 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suo @SherlockNoMad what's the status on the TE pass? Do we have to maintain that or can we delete?
I do kind of think it probably would be ok to drop OSS testing |
@cyyever we can't find much usage of this indeed. |
@albanD What files did you mean? |
Yes. So you can remove the whole llvm9 requirement |
wdym internal builds? |
#158928 has been reverted because the tensorexpr tests are used internally. |
@cyyever I didn't had time to forward fix before it was reverted. From what I've seen, it is mostly build file update and utils being used from the deleted code. |
@cyyever I guess this needs clean rebase on top of trunk |
@albanD Done |
bab21ea
to
399bb4e
Compare
Signed-off-by: cyy <cyyever@outlook.com>
To test tensorexpr code, LLVM 9 was installed in CI. However, tensorexpr tests have been removed, so we shouldn't install LLVM libraries.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd