Skip to content

Don't use LLVM libraries #158623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't use LLVM libraries #158623

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jul 18, 2025

To test tensorexpr code, LLVM 9 was installed in CI. However, tensorexpr tests have been removed, so we shouldn't install LLVM libraries.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@cyyever cyyever requested review from jeffdaily and a team as code owners July 18, 2025 02:55
Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158623

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Cancelled Job

As of commit cfa4291 with merge base 0d40ff3 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jul 18, 2025
@facebook-github-bot facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Jul 18, 2025
@cyyever cyyever requested a review from malfet July 18, 2025 03:57
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 22, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased llvm onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout llvm && git pull --rebase)

@cyyever cyyever requested a review from albanD July 22, 2025 04:10
@cyyever cyyever added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jul 22, 2025
@cyyever cyyever requested a review from ezyang July 22, 2025 04:37
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suo @SherlockNoMad what's the status on the TE pass? Do we have to maintain that or can we delete?

@ezyang
Copy link
Contributor

ezyang commented Jul 23, 2025

I do kind of think it probably would be ok to drop OSS testing

@albanD
Copy link
Collaborator

albanD commented Jul 23, 2025

@cyyever we can't find much usage of this indeed.
Let's drop the test altogether!

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 23, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 23, 2025

@albanD What files did you mean?

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 23, 2025

@albanD @ezyang Did you mean remove all of test/cpp/tensorexpr?

@albanD
Copy link
Collaborator

albanD commented Jul 23, 2025

Yes. So you can remove the whole llvm9 requirement

@cyyever cyyever marked this pull request as draft July 24, 2025 15:37
@cyyever cyyever marked this pull request as ready for review July 30, 2025 01:43
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 30, 2025

@albanD @ezyang Internal builds still rely on the tests, so should we consider this PR?

@ezyang
Copy link
Contributor

ezyang commented Aug 1, 2025

wdym internal builds?

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 1, 2025

wdym internal builds?

#158928 has been reverted because the tensorexpr tests are used internally.

@albanD
Copy link
Collaborator

albanD commented Aug 4, 2025

@cyyever I didn't had time to forward fix before it was reverted. From what I've seen, it is mostly build file update and utils being used from the deleted code.

@malfet
Copy link
Contributor

malfet commented Aug 4, 2025

+1 on what @albanD and @ezyang have said: let's just stop testing it in OSS altogether, and I can take a stab at removing the code altogether on Friday (it's probably not used internally at all, but build rules for it still exist

@albanD
Copy link
Collaborator

albanD commented Aug 11, 2025

@cyyever I guess this needs clean rebase on top of trunk

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 11, 2025

@albanD Done

@cyyever cyyever changed the title Don't use LLVM 9 Don't use LLVM libraries Aug 11, 2025
@cyyever cyyever force-pushed the llvm branch 3 times, most recently from bab21ea to 399bb4e Compare August 12, 2025 05:57
Signed-off-by: cyy <cyyever@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR module: rocm AMD GPU support for Pytorch open source release notes: releng release notes category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants