Fixes for collections.NamedTuple
#159367
Open
Fixes for collections.NamedTuple
#159367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159367
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit 196d4ae with merge base aeb5321 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 29, 2025
|
test? Especially for the |
Skylion007
reviewed
Aug 3, 2025
torch/_dynamo/polyfills/__init__.py
Outdated
| @@ -101,6 +101,10 @@ def accumulate_grad(x, new_grad): | |||
| x.grad.add_(new_grad_strided) | |||
|
|
|||
|
|
|||
| def is_iterable(obj): | |||
There was a problem hiding this comment.
Use a typing_extensions.TypeIs[Iterable] as a return type to propagate the type narrowing.
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
set_fullgraph(False)intest_collections#159902list(UserDefinedObject)viaforce_unpack_var_sequence#159864next(iterator, default)#159483collections.Counter#159368collections.NamedTuple#159367MutableMappingVariabletoAttributeMutationNew#159366cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @mlazos