Move config/util to AllocatorConfig for cross-allocator sharing #159553
+63
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159553
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit d665023 with merge base 2507ae6 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
commented
Jul 31, 2025
| constexpr size_t kMinLargeAlloc = | ||
| 10485760; // allocations between 1 and 10 MiB may use kLargeBuffer | ||
| constexpr size_t kRoundLarge = 2097152; // round up large allocations to 2 MiB | ||
|
|
There was a problem hiding this comment.
All configs/utils are defined in cpp file, so no BC issue.
Skylion007
reviewed
Jul 31, 2025
c10/core/AllocatorConfig.h
Outdated
| return size; | ||
| } | ||
|
|
||
| TORCH_CHECK(divisions >= 2, "Only 2 or more divisions are supported"); |
There was a problem hiding this comment.
Nit should be TORCH_CHECK_VALUE so it raises value error.
|
Adding |
|
@albanD May I know if this PR is reasonable to you? |
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
Make CUDA and XPU share the same config and code. And allow the other backends to reuse them.