Skip to content

[Inductor] Revert minimal changes to avoid internal test failures #159809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Inductor] Revert minimal changes to avoid internal test failures #159809

wants to merge 2 commits into from
+0 −5

Conversation

andyanwang
Copy link
Contributor

@andyanwang andyanwang commented Aug 4, 2025 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

The diff/PR #159211 caused a bunch of test failures for graph compiler(T232684410). But I couldn't figure out a forward fix so far. So with this diff/PR, I'm proposing to revert the minimal changes to resolve the test failures.

I'll continue the debugging, and re-land the reverted changes once we find out a forward fix.

Differential Revision: D79221721

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @egienvalue

@andyanwang
[Inductor] Revert minimal changes to avoid internal test failures
78afe9a 
The diff/PR #159211 caused a bunch of test failures for graph compiler(T232684410). But I couldn't figure out a forward fix so far. So with this diff/PR, I'm proposing to revert the minimal changes to resolve the test failures.

I'll continue the debugging, and re-land the reverted changes once we find out a forward fix.

Differential Revision: [D79221721](https://our.internmc.facebook.com/intern/diff/D79221721/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159809

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (3 Unrelated Failures)

As of commit e6b4674 with merge base 8bc843a (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

andyanwang added a commit that referenced this pull request Aug 4, 2025
@andyanwang
[Inductor] Revert minimal changes to avoid internal test failures
b05508f 
The diff/PR #159211 caused a bunch of test failures for graph compiler(T232684410). But I couldn't figure out a forward fix so far. So with this diff/PR, I'm proposing to revert the minimal changes to resolve the test failures.

I'll continue the debugging, and re-land the reverted changes once we find out a forward fix.

Differential Revision: [D79221721](https://our.internmc.facebook.com/intern/diff/D79221721/)

ghstack-source-id: 299427249
Pull Request resolved: #159809
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79221721

@andyanwang andyanwang requested a review from eellison August 4, 2025 22:36
@andyanwang andyanwang added topic: not user facing topic category module: mtia Device MTIA related issues labels Aug 4, 2025
@andyanwang
Update on "[Inductor] Revert minimal changes to avoid internal test f…
e6b4674 
…ailures"

The diff/PR #159211 caused a bunch of test failures for graph compiler(T232684410). But I couldn't figure out a forward fix so far. So with this diff/PR, I'm proposing to revert the minimal changes to resolve the test failures.

I'll continue the debugging, and re-land the reverted changes once we find out a forward fix.

Differential Revision: [D79221721](https://our.internmc.facebook.com/intern/diff/D79221721/)

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela egienvalue

[ghstack-poisoned]
andyanwang added a commit that referenced this pull request Aug 4, 2025
@andyanwang
[Inductor] Revert minimal changes to avoid internal test failures
f9f65ec 
Pull Request resolved: #159809

The diff/PR #159211 caused a bunch of test failures for graph compiler(T232684410). But I couldn't figure out a forward fix so far. So with this diff/PR, I'm proposing to revert the minimal changes to resolve the test failures.

I'll continue the debugging, and re-land the reverted changes once we find out a forward fix.

Differential Revision: [D79221721](https://our.internmc.facebook.com/intern/diff/D79221721/)
ghstack-source-id: 300684689
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79221721

@andyanwang
Copy link
Contributor Author

I don't understand why the red signals failed
image

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 4, 2025
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Check mergeability of ghstack PR / ghstack-mergeability-check

Details for Dev Infra team Raised by workflow job

@izaitsevfb
Copy link
Contributor

@pytorchbot merge -f 'unrelated failure'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@andyanwang andyanwang mentioned this pull request Aug 7, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Aug 10, 2025
@andyanwang @pytorchmergebot
[Inductor] Add back the revert part (#160054)
05c19d1 
Add back the reverted code(#159809) as we've figured out the actual root cause of the internal test failures. Mote details in the internal diff.
Rollback Plan:

Differential Revision: D79776691

Pull Request resolved: #160054
Approved by: https://github.com/blaine-rister
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@blaine-rister blaine-rister blaine-rister approved these changes

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: dynamo module: mtia Device MTIA related issues topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andyanwang @facebook-github-bot @pytorchmergebot @izaitsevfb @eellison @blaine-rister