Skip to content

[Feature Request] SSL Certificate for pytorch.org #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alanyee opened this issue Nov 9, 2017 · 5 comments
Closed

[Feature Request] SSL Certificate for pytorch.org #11

alanyee opened this issue Nov 9, 2017 · 5 comments

Comments

@alanyee
Copy link

alanyee commented Nov 9, 2017

There is a valid one https://discuss.pytorch.org/, and there seems to be a valid one for https://download.pytorch.org/. But https://pytorch.org/ is invalid.
@soumith
Copy link
Member

soumith commented Nov 9, 2017

the https for pytorch.org comes from github. github pages have no proper / official way yet of having https for custom domains

@bittlingmayer
Copy link

@soumith, you're right that it's not trivial, but I have HTTPS for custom domains using GitHub Pages, for example https://vectorhack.com/, https://censormap.org.

You should just use CloudFlare: https://gist.github.com/cvan/8630f847f579f90e0c014dc5199c337b

@bittlingmayer
Copy link

I wonder if this could be causing #14.

@alanyee
Copy link
Author

alanyee commented May 4, 2018

@soumith https://blog.github.com/2018-05-01-github-pages-custom-domains-https/

@soumith
Copy link
Member

soumith commented May 4, 2018

We already enabled https using the new github feature earlier this week. Hurray!!!

@soumith soumith closed this as completed May 4, 2018
JoelMarcey pushed a commit that referenced this issue Sep 19, 2018
@brsoff
[PYT-82] Use local font files, remove font CDN (#11)
c8aeab6
JoelMarcey added a commit that referenced this issue Sep 19, 2018
@JoelMarcey
Add supported Windows versions (#11)
c769207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soumith @alanyee @bittlingmayer