Skip to content

Link preview is not working on Telegram, Twitter, Slack... #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bittlingmayer opened this issue Jan 24, 2018 · 2 comments
Closed

Link preview is not working on Telegram, Twitter, Slack... #14

bittlingmayer opened this issue Jan 24, 2018 · 2 comments

Comments

@bittlingmayer
Copy link

The HTML is somehow mal-formed, because none of the major platforms show a preview for the blog post links like http://pytorch.org/2018/01/19/a-year-in.html.

Optimisation for mobile is working (eg Firefox, which uses Readability), beyond that I have not investigated what the exact issue is.

Here is a screenshot from Telegram for macOS:

screen shot 2018-01-24 at 18 58 52
@bittlingmayer bittlingmayer changed the title Preview is not working on Telegram, Twitter, Slack... Link preview is not working on Telegram, Twitter, Slack... Jan 24, 2018
@bittlingmayer
Copy link
Author

In some sense this would complete #8.

@bittlingmayer bittlingmayer mentioned this issue Jan 24, 2018
Closed
@goodlux
Copy link

goodlux commented Jun 28, 2018

I think the issue here is that the blog pages don't currently support open graph meta data.

This tool shows the issues, with the link you provided:

https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fpytorch.org%2F2018%2F05%2F02%2Froad-to-1.0.html

I just fixed the basics for the home page, I think it is relatively easy to do for the blog pages as well.

goodlux pushed a commit to goodlux/pytorch.github.io that referenced this issue Jun 28, 2018
Added meta tags for blog posts, Should fix issue pytorch#14
83c6ff8
soumith pushed a commit that referenced this issue Jun 29, 2018
@goodlux @soumith
added META tags to support link sharing in Messenger and elsewhere (#38)
dc4aea0 
* added META tags to support link sharing on Facebook, in Messenger, and elsewhere.

* Added meta tags for blog posts, Should fix issue #14
JoelMarcey pushed a commit that referenced this issue Sep 19, 2018
@brsoff
[PYT-86] Wire up blog author (#14)
1a4f4e8
JoelMarcey pushed a commit that referenced this issue Sep 19, 2018
@ericnakagawa
Merge pull request #14 from JoelMarcey/deselect-bug
77dea98 
Remove info on cloud deselect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@goodlux @JoelMarcey @bittlingmayer