Skip to content

Conversation

LucasH-rp
Copy link
Contributor

@LucasH-rp LucasH-rp commented Sep 4, 2025

Added 2 device tree overlays for the rpi-control-hat. One for 'bottom' mode and one for 'top' mode.

Copy link
Contributor

@pelwell pelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few inline comments, but the main issues that that the automatic checks will flag up is that every overlay needs a rule in the Makefile to build it and an entry in the README file.

target-path = "/";
__overlay__ {
rpi_power_hat_b: rpi-power-hat-b {
compatible = "Raspberry Pi,rpi-power-hat-b";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct prefix for Raspberry Pi Ltd. is "raspberrypi".

};
};
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git prefers all files to end with a newline.

power2-monitor = <&pwr2_monitor>;

// HAT metadata
hat-name = "rpi-power-hat Bottom";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this is meant to do. If it's for human readability, the compatible string should be enough.

@@ -247,6 +247,8 @@ dtbo-$(CONFIG_ARCH_BCM2835) += \
rpi-fw-uart.dtbo \
rpi-poe.dtbo \
rpi-poe-plus.dtbo \
rpi-power-hat-b-overlay.dtbo \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The make rules transform *-overlay.dts into *.dtbo, so drop the -overlays here.

@pelwell
Copy link
Contributor

pelwell commented Sep 4, 2025

If you run scripts/checkpatch.pl -g HEAD in your branch you'll see there are still some errors, and some warnings that are easy to fix like moving the SPD-X lines to the top. You also need 2 blank lines between README entries.

@pelwell
Copy link
Contributor

pelwell commented Sep 4, 2025

And the overlay entries in README and Makefile must be in alphabetical order.

@LucasH-rp
Copy link
Contributor Author

Checkpatch is complaining about undocumented DT compatible strings and MAINTAINERS needing updating - is it okay to ignore these warnings?

@pelwell
Copy link
Contributor

pelwell commented Sep 4, 2025

Yes, I'll waive those.

Added 2 overlays for the rpi-power HAT to operate in
either TOP or BOTTOM mode.
Modified makefile and readme accordingly

Signed-off-by: Lucas Hoffmann <lucas.hoffmann@raspberrypi.com>
@pelwell pelwell merged commit 74cc78f into raspberrypi:rpi-6.12.y Sep 4, 2025
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Sep 5, 2025
kernel: configs: Add EROFS_FS_ZIP_ZSTD
See: raspberrypi/linux#7028

kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400
See: raspberrypi/linux#7031

kernel: mfd: rp1: Fix device links when modules disabled
See: raspberrypi/linux#7027

kernel: Add adxl355 to i2c-sensor
See: raspberrypi/linux#6823

kernel: dtoverlays: Switch ssd1306 to use the DRM driver
See: raspberrypi/linux#7034

kernel: Added device tree overlays for the rpi-power HAT
See: raspberrypi/linux#7036

kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8
See: raspberrypi/linux#7037
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Sep 5, 2025
kernel: configs: Add EROFS_FS_ZIP_ZSTD
See: raspberrypi/linux#7028

kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400
See: raspberrypi/linux#7031

kernel: mfd: rp1: Fix device links when modules disabled
See: raspberrypi/linux#7027

kernel: Add adxl355 to i2c-sensor
See: raspberrypi/linux#6823

kernel: dtoverlays: Switch ssd1306 to use the DRM driver
See: raspberrypi/linux#7034

kernel: Added device tree overlays for the rpi-power HAT
See: raspberrypi/linux#7036

kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8
See: raspberrypi/linux#7037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants