Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Serves new content if config.json is changed #20

Closed
wants to merge 2 commits into from
Closed

Serves new content if config.json is changed #20

wants to merge 2 commits into from

Conversation

dcfix
Copy link

@dcfix dcfix commented Jan 29, 2015

Fix for issue #13

@zpao
Copy link
Member

zpao commented Feb 2, 2015

This is looking good, but a couple comments first:

So if you could make the right changes in the other implementations, that would be awesome!

@dcfix
Copy link
Author

dcfix commented Feb 3, 2015

I'll figure out how to reset my fork and get it submitted. Should I submit
the python and ruby files as one pull request or two?

Thanks,
Darren

On Mon Feb 02 2015 at 12:45:11 PM Paul O’Shannessy notifications@github.com
wrote:

This is looking good, but a couple comments first:

So if you could make the right changes in the other implementations, that
would be awesome!


Reply to this email directly or view it on GitHub
#20 (comment).

@zpao
Copy link
Member

zpao commented Feb 3, 2015

Keeping it in this PR is fine.

Also, it looks like our bot wasn't set up right for this repo. Can you sign the CLA - https://code.facebook.com/cla? We'll need that before we can merge the changes.

@@ -26,6 +26,7 @@
end

# always return json
comments = react_version = JSON.parse(File.read('./_comments.json'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be before the handling of POST (we could also drop the global comments and react_version)

@zpao
Copy link
Member

zpao commented Feb 6, 2015

Ah, picked this up with a combo of other changes tonight. But if we missed anything or you have other suggestions, let me know!

@zpao zpao closed this Feb 6, 2015
@dcfix
Copy link
Author

dcfix commented Feb 6, 2015

Thanks - got hung up trying to figure out git rebasing. Maybe next time.

shenxl pushed a commit to shenxl/react-tutorial that referenced this pull request Sep 15, 2015
fix package.json repository field not to have npm warning
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants