This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Move _comments.json read into proc #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this file is read outside the proc, the server will never see updates to the json file and the response will always be the same. This allows manual editing/saving of the _comments.json file to be reflected in subsequent requests.
shenxl
pushed a commit
to shenxl/react-tutorial
that referenced
this pull request
Sep 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this file is read outside the proc, the server will never see updates to the json file and the response will always be the same. This allows manual editing/saving of the _comments.json file to be reflected in subsequent requests.