Improve json section #515
Improve json section #515
Conversation
| @@ -39,10 +39,48 @@ You can also convert a the following to JSON: | |||
| print(json.dumps(d)) | |||
| '{"first_name": "Guido", "last_name": "Rossum", "titles": ["BDFL", "Developer"]}' | |||
|
|
|||
| Working with File Objects | |||
| ------------------------- | |||
There was a problem hiding this comment.
Didn't we discuss in an earlier PR that we weren't going to cover working with file objects?
There was a problem hiding this comment.
I didn't see any such discussion in the previous JSON PRs.
Why not cover working with file objects? Parsing JSON from a file and writing JSON to an output file is a pretty common use case of the JSON library.
There was a problem hiding this comment.
Please read the review comments on https://github.com/kennethreitz/python-guide/pull/511
There was a problem hiding this comment.
Got it, thanks! I couldn't see the comments on the outdated diffs before.
I'll remove the file object sections.
ᐧ
On Tue, Feb 10, 2015 at 10:00 PM, Ian Cordasco notifications@github.com
wrote:
In docs/scenarios/json.rst
https://github.com/kennethreitz/python-guide/pull/515#discussion_r24473205
:@@ -39,10 +39,48 @@ You can also convert a the following to JSON:
print(json.dumps(d))
'{"first_name": "Guido", "last_name": "Rossum", "titles": ["BDFL", "Developer"]}'+Working with File Objects
+-------------------------Please read the review comments on #511
https://github.com/kennethreitz/python-guide/pull/511—
Reply to this email directly or view it on GitHub
https://github.com/kennethreitz/python-guide/pull/515/files#r24473205.
Matthew Lewis
mplewis.com | (612) 600-6907
This reverts commit 2e2d70c.
|
Just removed the section on file objects—let me know if you find anything else you think should be changed. |
|
Thanks @mplewis ! |
I've added the following to the JSON section:
I've also reworded the intro paragraph a little and cleaned up the language of the simplejson paragraph.
Please take a look and tell me what you think! Thanks.