Skip to content

[DOCS] : Splash Menu Pages #7756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[DOCS] : Splash Menu Pages #7756

wants to merge 6 commits into from

Conversation

royendo
Copy link
Contributor

@royendo royendo commented Aug 8, 2025 •
edited
Loading

needs #7754 done

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@royendo royendo requested a review from ericpgreen2 August 11, 2025 22:45
@royendo
Copy link
Contributor Author

royendo commented Aug 11, 2025

you'll notice a few commented lines in the splash page for files to be added/moved in #7717

ericpgreen2
ericpgreen2 approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments. If needed, happy to take a second look.

Overall, the form factor of these pages is great! They really help set context as you browse the docs.

docs/docs/manage/index.md Outdated
Comment on lines 20 to 21
- **[Dashboard Access Policies](/manage/security)** - Configure granular access controls for your dashboards and data
- **[Roles and Permissions](/manage/roles-permissions)** - Set up user roles and define permission levels.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out-of-order from the sidebar's sequence.

Also, the "Roles and Permissions" description doesn't make it immediately clear to me how it differs from the "Dashboard Access Policies"– I think conceivably "user roles and permission levels" also could be used to manage data access?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard Access Policies is moving soon to metrics as data access policies, since its technically not just dashboards, apis etc. and thats where they are defined, explore/canvas also getting some more content around security in #7717.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidd made an interesting point where searching for permissions, he wasn;t able to find this page immediately, so want to look into reworking these pages too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but small PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royendo @ericpgreen2