-
Notifications
You must be signed in to change notification settings - Fork 144
[DOCS] : Splash Menu Pages #7756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
you'll notice a few commented lines in the splash page for files to be added/moved in #7717 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with comments. If needed, happy to take a second look.
Overall, the form factor of these pages is great! They really help set context as you browse the docs.
docs/docs/manage/index.md
Outdated
- **[Dashboard Access Policies](/manage/security)** - Configure granular access controls for your dashboards and data | ||
- **[Roles and Permissions](/manage/roles-permissions)** - Set up user roles and define permission levels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out-of-order from the sidebar's sequence.
Also, the "Roles and Permissions" description doesn't make it immediately clear to me how it differs from the "Dashboard Access Policies"– I think conceivably "user roles and permission levels" also could be used to manage data access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard Access Policies is moving soon to metrics as data access policies, since its technically not just dashboards, apis etc. and thats where they are defined, explore/canvas also getting some more content around security in #7717.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidd made an interesting point where searching for permissions, he wasn;t able to find this page immediately, so want to look into reworking these pages too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but small PRs :)
@@ -8,21 +8,28 @@ tags: | |||
|
|||
# Welcome to Rill Guides and Tutorials! | |||
|
|||
### We're thrilled you've joined us on this Th-Rill-ing journey! | |||
### We're thrilled you've joined us on this thrilling journey! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
- **[Build Custom APIs](/integrate/custom-apis)** - See the different types of APIs to build | ||
- **[Integrate with Custom APIs](/integrate/custom-api)** - Build custom APIs to retrieve aggregated data from your metrics views |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: These descriptions don't seem to cleanly match the "Build Custom APIs" and "Integrate with Custom APIs" titles
needs #7754 done
Checklist: