Fix determing if option inside magic comments requires an arguement #9562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test:
$ echo '#!ruby -0 --disable' > file.rb
$ ruby file.rb
Ruby crashed with segmentation fault, because is_option_with_arg("disable", Qtrue, Qtrue) in ruby.c:1399
(per tree of commit 7b6731b)
returned true, while it must return false.
But
$ ruby -0 --disable
does not crash, is_option_with_arg("disable", Qtrue, Qtrue) in ruby.c:1399 correctly returns false.
I suspect that a good fix must be done somewhere else,
but I cannot understand the difference between two cases described above,
so just adding a check.
Closed
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Jan 17, 2024
nobu
added a commit
that referenced
this pull request
Jan 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
Ruby crashed with segmentation fault, because
is_option_with_arg("disable", Qtrue, Qtrue)in ruby.c:1399 (per tree of commit 7b6731b) returned true, while it must return false.But
does not crash,
is_option_with_arg("disable", Qtrue, Qtrue)in ruby.c:1399 correctly returns false.I suspect that a good fix must be done somewhere else, but I cannot understand the difference between two cases described above, so just adding a check.
Not sure that this patch does not break anything.