-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fix default gemspec file list for extension gems #9673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default gemspec file list for extension gems #9673
Conversation
I also added an extra change to generate requirable features directly in this file list (without |
Sorry to late response. I'll look tomorrow. |
I confirmed this change to add I checked all of gemspec with this PR and without one. https://gist.github.com/hsbt/520371620754e4be7ce01d358598b6c4 I found two things:
|
Thanks for checking! No, it's not expected. I will have a look and try to fix those 👍. |
5e62374
to
4b3f332
Compare
@hsbt I looked into both issues, I think it should be correct now! |
Instead of hardcoded "ext".
So that it also includes requirable features provided by extensions.
It holds the root directory for each type of default gem (ext/ or lib/).
4b3f332
to
126e51a
Compare
@deivid-rodriguez Thanks. I'll look this at next week. |
@deivid-rodriguez I confirmed to fix my comment. https://gist.github.com/hsbt/91aa79a2bfdf14ba95cb83e262ab41b8 Let's try this. |
This change leads to fail with cross-build. https://rubyci.s3.amazonaws.com/crossruby/crossruby-master-arm/log/20240325T034328Z.fail.html.gz I'll look that. |
We should fix ruby#9673 for Ruby 3.3.1
Thanks! Let me know if help is needed with that failure. |
This breaks Windows builds. Below is only ucrt build, note that no extension gems are listed. First noticed in ruby-loco, as the 'CLI test' failed. Windows mswin builds have the same problem, but the 'Windows' CI doesn't run Last master CI before this was committed: PR CI: CI in master: |
@hsbt Thank you for the quick fix. As you've probably seen, fixed the CI here. All three ruby-loco builds also passed... |
Thank you both! |
This is work to fix:
and
require "stringio"
rubygems/rubygems#7160