Skip to content

Fix markup issues #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2019
Merged

Fix markup issues #1987

merged 3 commits into from
Mar 4, 2019

Conversation

spk
Copy link
Contributor

@spk spk commented Mar 3, 2019

Hi just fixing some markup errors found while working on #1420 in case this is not merged; cheers

@spk spk requested review from a team as code owners March 3, 2019 15:37
@hsbt hsbt merged commit 1179e69 into ruby:master Mar 4, 2019
@spk spk deleted the fix-markup-issues branch March 4, 2019 09:27
@stomar
Copy link
Contributor

stomar commented Mar 4, 2019

@spk Thanks for catching those errrors! But please avoid silently introducing unrelated changes.

Also thanks to @znz.

@spk
Copy link
Contributor Author

spk commented Mar 4, 2019

Sorry again I did not know fixed in #1988 by @znz thanks

@spk spk mentioned this pull request Mar 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znz znz znz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spk @stomar @znz @hsbt