Skip to content

class Fixnum to class Integer in documentation/ruby-from-other-languages #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2019

Conversation

znz
Copy link
Member

@znz znz commented Sep 3, 2019

by git grep -l 'class Fixnum' | xargs perl -pli -e 's/Fixnum/Integer/'

After Integer unification in Ruby 2.4.0, users should use class Integer instead of class Fixnum.

Only de documentation mentions Active Support's #hours.
It may be Numeric#hours. But I don't care it.

…nguages

by `git grep -l 'class Fixnum' | xargs perl -pli -e 's/Fixnum/Integer/'`

After Integer unification in Ruby 2.4.0, users should use `class Integer` instead of `class Fixnum`.

Only de documentation mentions Active Support's `#hours`.
It may be `Numeric#hours`. But I don't care it.
@znz znz requested review from a team as code owners September 3, 2019 04:17
Copy link
Member

@goz goz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID translation looks good 👍

@jcserracampos jcserracampos requested a review from a team September 3, 2019 09:42
@jcserracampos
Copy link
Member

PT translation is fine.

Copy link
Member

@hlcfan hlcfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-Authored-By: Chayoung You <yousbe@gmail.com>
@JuanitoFatas JuanitoFatas merged commit 11069b7 into ruby:master Sep 22, 2019
@JuanitoFatas
Copy link
Member

👍 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants