-
Notifications
You must be signed in to change notification settings - Fork 631
class Fixnum
to class Integer
in documentation/ruby-from-other-languages
#2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nguages by `git grep -l 'class Fixnum' | xargs perl -pli -e 's/Fixnum/Integer/'` After Integer unification in Ruby 2.4.0, users should use `class Integer` instead of `class Fixnum`. Only de documentation mentions Active Support's `#hours`. It may be `Numeric#hours`. But I don't care it.
yous
reviewed
Sep 3, 2019
goz
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID translation looks good 👍
lex111
approved these changes
Sep 3, 2019
jcserracampos
approved these changes
Sep 3, 2019
jcserracampos
approved these changes
Sep 3, 2019
PT translation is fine. |
hlcfan
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bugtender
approved these changes
Sep 3, 2019
Co-Authored-By: Chayoung You <yousbe@gmail.com>
yous
approved these changes
Sep 11, 2019
👍 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by
git grep -l 'class Fixnum' | xargs perl -pli -e 's/Fixnum/Integer/'
After Integer unification in Ruby 2.4.0, users should use
class Integer
instead ofclass Fixnum
.Only de documentation mentions Active Support's
#hours
.It may be
Numeric#hours
. But I don't care it.