Switch off autoplay in 2.7.0-rc1 post #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nurse Some feedback would be welcome, especially in regard to the upcoming final release. |
|
I think it is better to make this kind of language-agnostic changes to all translations since it is faster to make them on one branch than making them on different branchs via different PRs. |
|
Sorry about the comment above, I have thought that there was corresponding Turkish translation but I have realized that it wasn't merged yet. |
|
I think it should be autoplay because the video is just a decoration and readers feel the experience. |
|
ACK; fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more annoying than helping. At the time when one reaches the paragraph, the video has been playing for some time already, and one needs to stop and rewind. It's better to simply start the video at the time one wants to see it.