Git commands should not all be chomped by default #347
Comments
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@perlun or anyone else. Are there any plans to address this issue? Or is there any additional information you need from me? |
|
@dhollinger I agree from reading the issue now - like you say, it should be addressed. If you don't mind, please submit a PR and I'll happily look at it. |
|
@perlun I'll take a look at it over the weekend and see what I can come up with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not all git subcommand output should be chomped by default.
For example,
git showshould never have its results chomped because when it does it does actually return different content AND a different MD5 Sum hash than what is actually stored in the git repository.This is incredibly important for automation and config management systems that rely on the results of a
git showto determine if file contents on disk have changed or not. Even though this is potentially an outlier use case, the fact remains that the content of a file pulled from a git commit should NEVER be munged, chomped, or modified in any other way that will return different content than what is actually stored in the git commit.The text was updated successfully, but these errors were encountered: