Git::Lib#escape does not work, escapes incorrectly #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tadman opened this issue Nov 12, 2009 · 0 comments

Milestone

tadman commented Nov 12, 2009

The escape mechanism for handling filenames with single quotes in them is repeating text, not escaping at all.

s = "it's"
# Original
escaped = s.to_s.gsub('\'', '\'\\\'\'') # => "it's's"
%Q{"#{escaped}"} #=> "\"it's's\""

# Patched
%Q{"#{s.to_s.gsub("'") { "\\'" }}"} # => "\"it\\'s\""

Looks like gsub placeholders are kicking in accidentally.

sheerun mentioned this issue

Update escaping for file names to handle files with single quotes #39

Closed

robertodecurnex closed this as completed in

d9556b4

robertodecurnex mentioned this issue

Adding a file with single quote throws error #129

Closed

robertodecurnex added a commit that referenced this issue


          Improving how we escape single quotes refs #129 #5 #112 #95 #39

5ff106a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment