Skip to content

Bug on def escape(s) on lib/git/lib.rb #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xbeta opened this issue Sep 5, 2013 · 1 comment
Closed

Bug on def escape(s) on lib/git/lib.rb #95

xbeta opened this issue Sep 5, 2013 · 1 comment
Milestone
1.2.7

Comments

@xbeta
Copy link

xbeta commented Sep 5, 2013

The current implementation doesn't really escape anything if the string param contains a single quote, it makes a copy and replace it.

─○ irb
1.9.3-p448 :001 > msg="'8.00.0'"
 => "'8.00.0'"
1.9.3-p448 :002 > msg.to_s.gsub('\'', '\'\\\'\'')
 => "'8.00.0''8.00.0''"
1.9.3-p448 :003 >
@robertodecurnex
Copy link
Contributor

fixed at d9556b4

@robertodecurnex robertodecurnex mentioned this issue Feb 5, 2014
Closed
robertodecurnex added a commit that referenced this issue Feb 5, 2014
@robertodecurnex
Improving how we escape single quotes refs #129 #5 #112 #95 #39
5ff106a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.7
Development

No branches or pull requests
2 participants
@robertodecurnex @xbeta