Ty @mbishop-fiksu ! I've started that over the thread_safety branch, just fixing the worst of these chdirs.
Let's see what's wrong with Travis and how can we make the gem even more safe (time will tell if there are still other spots for thread problems).

Note that I took the --git-dir and --work-tree way to run the commands. I'll see how can we mege efforts.

Hey @mbishop-fiksu can you please rebase your branch to master and push -f it ?

There was a problem with dates and tests.

Ty.

I'd be happy to. I'll get to this after the thanksgiving break. Thank you for the heads up!

Ok, rebased and pushed. There is still a Ruby 1.8 incompatibility (I'm using Open3.capture2) so I'll try and work around that.

I've re-added back 1.8-compatibility, but at the cost of re-adding the Dir.chdir calls. popen doesn't accept a hash of options where we could add the chdir option.

I'm not sure the failure in the test suite is the code. What do you think?

It's a build problem, happens frequently for some ruby versions (not our fault).

Just sent a re-run, hope that will work. If not we should probably wait and try again later.

Bah, same thing. Ok, we'll wait I guess...

@robertodecurnex Think it's worth hitting that test up again or should we wait a little more? Also, I can't remove all the Dir.chdir statements for Ruby 1.8. Think that's a showstopper?

Ruby 1.8 compatibility is definitely a show-stopper for the 1.x line.

Since there are a bunch of Ruby 1.8 issues that can be easily solved with Ruby >= 1.9 I will be removing 1.8 support on git 2.0 (the next release after 1.2.9).

I'll take your changes to the thread_safety branch and that would be probably the code base for 2.0.

@robertodecurnex I think this could still be considered for the 1.2.9 release and here's my reasoning. The change improves thread-safety for rubies from 1.9 on while the behavior remains the same for rubies < 1.9. Additionally, no public interface is changed. It doesn't fail on ruby 1.8. It remains the same. What do you think?

@mbishop-fiksu I just came across this when trying to use ruby-git multithreaded. With the current state of 0f78b67, can you still fetch/init/checkout in parallel without chdir-related problems?

@jbohren since your problems would be just on the way that command make the system calls you should be fine using this branch: https://github.com/schacon/ruby-git/tree/thread_safety

Mostly of the thread safety improvements will be also available under the next release (soon).

@jbohren since your problems would be just on the way that command make the system calls you should be fine using this branch: https://github.com/schacon/ruby-git/tree/thread_safety

Cool, I'll check that out. Thanks!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.