Tests #317
Closed
Tests #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Chacon <schacon@gmail.com>
Signed-off-by: Scott Chacon <schacon@gmail.com>
…/javascript as is proper Signed-off-by: Scott Chacon <schacon@gmail.com>
Signed-off-by: Scott Chacon <schacon@gmail.com>
Signed-off-by: Scott Chacon <schacon@gmail.com>
Signed-off-by: Scott Chacon <schacon@gmail.com>
-- check binary - attr_reader from, to (I refer to commit sha1.) Signed-off-by: Scott Chacon <schacon@gmail.com>
usage: git.log(30).skip(10).to_a Signed-off-by: Scott Chacon <schacon@gmail.com>
Signed-off-by: Scott Chacon <schacon@gmail.com>
add $VERBOSE = true for the tests
…* exist?) Note: I'm not entirely sure if this is the correct fix, however, it fixes errors in the test suite, and I'll assume completeness on the part of the tests.
Conflicts: lib/git/lib.rb
Signed-off-by: elliottcable <github.com@elliottcable.com>
…rnational/unicode characters).
…to make rubygems-1.3.2 happy.
When a submodule is cloned into another project, it has a different structure: The .git folder is well, not a folder, it is a file that's sole contents include a reference to where the .git folder for the submodule is on the local drive. Take that information from the .git *file* and then build our repository and index location out of this.
…GIT_SSH env value unless a custom value is set via `Git.configure` closes #212
v1.2.8 allowed setting of GIT_SSH to point to SSH wrapper; v1.2.9 overrides this with value of Git::Base.config.git_ssh. This is our story in our backlog: https://www.pivotaltracker.com/story/show/86059268. Signed-off-by: Frank Kotsianas <frankkotsianas@gmail.com>
…ument Error) #190 - from up-to-date master
Fix the encoding issue - 'split': invalid byte sequence in UTF-8 (up-to-date!!) closes #190
Conflicts: lib/git/diff.rb
Dropping ruby 1.8.x support
Updated Travis badge
* Fixed unit tests to run again There were a few issues: - The `tar xvpf` approach didn't work for me locally, supposedly since I run macOS, where `tar` prints its output to `stderr` by default. The workaround is to redirect `stderr` to `stdout` while running the command. - The `tar` output also looked a bit different than before, so I changed it to use regexp matching instead of exact string matching (which is more fragile and prone to breakage.) - The `parent.parent` stuff apparently returns different values now than before. I have really no clue why, but: I think it's better to accept that fact and merge this, so we can start validating the changes people have suggested now. * Use JRuby 9 We are seeing test failures on JRuby 1.8 and 1.9 mode, and this is using an EOL JRuby anyway. Let's drop these versions in Travis now, and go with JRuby 9k instead. We still _support_ these older JRuby versions until 2.0 is released, when we should also drop Ruby 1.9, 2.0 and 2.1 support.
|
This PR seems to have the branches messed up; it tries to merge things into some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to edit the punctuation and grammar on this project but I didn't see an immediate way to do so. If I fork this project and clone it before pulling it down to my hard drive, will I be able to individually edit the files?