Creates CONTRIBUTOR and MAINTAINERS files #353

tarcinil · 2018-03-08T00:09:59Z

Created to create a standard review expectation for potential contributors and a clear representation of maintainers.

The MAINTAINERS file will help avoid issues like those created in #342 (comment)

closes #349

…is written in * adding CONTRIBUTING and MAINTAINERS markdown file based on projects that I have worked it (discussion still open for final) * adding new files and extension to gemspec Signed-off-by: Vern Burton <me@vernburton.com>

Signed-off-by: Vern Burton <me@vernburton.com>

tarcinil · 2018-03-08T01:05:03Z

The failure of jruby-9.1.15.0 in Travis CI seems to be a random occurrence. My change doesn't even change how the code works but it failed the test.

I would propose that we allow failures of jruby-9.1.15.0 in Travis. What do you think @perlun?

perlun · 2018-03-08T13:15:41Z

The failure of jruby-9.1.15.0 in Travis CI seems to be a random occurrence. My change doesn't even change how the code works but it failed the test.

You're right, it seems to be an intermittent error. I restarted the job now; it seemed to work better this time. JRuby threads are much more "real" threads than MRI (because of no GIL), so the level of concurrency is higher; that's likely to be the source of the difference here.

I would propose that we allow failures of jruby-9.1.15.0 in Travis. What do you think @perlun?

I am hesitant to do that, since it would easily allow us to miss real JRuby breakage (i.e. things that for whatever reason doesn't work there.) I'm a long-time JRuby user myself, and I know how annoying it is with gems that only work on MRI, so for the time being, I think it would be much better to look into the root cause for that intermittent error. There is an issue about it: #319

Will get back to reviewing the rest ASAP, it requires a bit more thought & time.

tarcinil · 2018-03-30T14:03:12Z

I will rebase the branch when I get home.

perlun · 2018-03-08T13:20:01Z

CONTRIBUTING.md

+
+### Submitting Issues
+
+We utilize **Github Issues** for issue tracking and contributions. You can contribute in two ways:


Minor nit: Github -> GitHub, both here and in the other places in the document.

I will do tonight.

perlun

Some open issues I'd like to see addressed before merge.

perlun · 2018-03-30T20:09:08Z

CONTRIBUTING.md

+    sign-off) is maintained indefinitely and may be redistributed
+    consistent with this project or the open source license(s)
+    involved.
+```


@rvodden I'm not so sure we need the DCO. It feels a bit far-fetched to me. What do you think?

I'm with you, in that it is a bit far fetched, but on the other hand all the OS projects i work on them have them... its only a check box, and I don't think its much to ask; On the other hand if we miss it out and have no legal protection at all we risk (admittedly and extremely low risk) losing all our work. I'm minded to leave it in...

I agree about the legal implications, they are valid. If it was only a check box, I would be fine with it, but as we have it written now:

In the commit message of the contribution, the developer simply adds a Signed-off-by statement and thereby agrees to the DCO, which you can find below or at http://developercertificate.org/.

...it means more work every time someone makes a single commit and submits it to the project. (OTOH, you can automate it by using git commit -s or --sign-off, but still...)

I think, if we rephrase this to be just a mere checkbox in the PR, I am fine with it.

@perlun I would be hesitate to change the standard for DCO without understand the legal implications that change could introduce. The DCO depends on the git Sign-Off-By because of the integrity that is built into Git, removing that could nullify the protections that are given to the maintainers of the project.

The IDE that I use has the ability to sign-off a commit built-in, but I do not believe that the addition of a -s in a command line string is asking too much either. GitHub has tools that can check for DCO on a commit.

The IDE that I use has the ability to sign-off a commit built-in, but I do not believe that the addition of a -s in a command line string is asking too much either. GitHub has tools that can check for DCO on a commit.

Alright, I'm willing to give it a try. We can drop this requirement later if it turns out to be too burdensome.

perlun · 2018-03-30T20:09:27Z

PULL_REQUEST_TEMPLATE.md

+### Your checklist for this pull request
+🚨Please review the [guidelines for contributing](../CONTRIBUTING.md) to this repository.
+
+- [ ] Ensure all commits include 


include what?

It should have been the DCO sign-off, but could be rendered moot by your other comments.

@tarcinil Fair enough. Ping me or @rvodden once you have it rebased and we'll give it another look.

@perlun My branch has been rebased and comments addressed.

The thread safety issue has also struck on the Ruby 2.1.10 inside of Travis.

* updating Github to GitHub * completing sentence for DCO signoff Signed-off-by: Vern Burton <me@vernburton.com>

stale · 2018-06-08T12:04:59Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

perlun · 2018-06-20T11:58:43Z

@tarcinil I merged this now. Please add the tool in GitHub that checks for DCO so we don't have to check that manually.

tarcinil · 2018-06-20T14:15:20Z

@perlun I would love to but I believe I would need to be added to the organization so that I can configure integrations.

Please see the integration located here:
https://github.com/probot/dco

Installation can be done through:
https://github.com/integration/dco

perlun · 2018-06-21T12:15:18Z

@tarcinil Sure, I'll add you - we need all the help we can get. Visit this page and you should be able to see your invitation: https://github.com/orgs/ruby-git/invitation

tarcinil · 2018-06-21T12:59:32Z

@perlun A request has been sent to install it.

A request to install DCO has been submitted on the @ruby-git account.

perlun · 2018-06-22T21:00:44Z

@tarcinil Great. I approved the request now, thanks for your efforts.

tarcinil added 5 commits March 7, 2018 18:01

fixing dco anchor

8f21f44

Signed-off-by: Vern Burton <me@vernburton.com>

using markdown formats

246c8ee

Signed-off-by: Vern Burton <me@vernburton.com>

adding pull request requirements and license information

6dcf2fc

Signed-off-by: Vern Burton <me@vernburton.com>

adding github templates for issues/pull requests

02d9a59

Signed-off-by: Vern Burton <me@vernburton.com>

rvodden approved these changes Mar 30, 2018

View reviewed changes

perlun reviewed Mar 30, 2018

View reviewed changes

perlun requested changes Mar 30, 2018

View reviewed changes

tarcinil added 2 commits April 4, 2018 20:30

Merge branch 'master' into feature/349

ea2a405

fixing comments to PR

5e9d79e

* updating Github to GitHub * completing sentence for DCO signoff Signed-off-by: Vern Burton <me@vernburton.com>

perlun approved these changes Apr 9, 2018

View reviewed changes

stale bot added the wontfix label Jun 8, 2018

Merge branch 'master' into feature/349

561f751

stale bot removed the wontfix label Jun 15, 2018

perlun merged commit 4aa6d1f into ruby-git:master Jun 20, 2018


		### Submitting Issues

		We utilize Github Issues for issue tracking and contributions. You can contribute in two ways:

Creates CONTRIBUTOR and MAINTAINERS files #353

Creates CONTRIBUTOR and MAINTAINERS files #353

Uh oh!

Conversation

tarcinil commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcinil commented Mar 8, 2018

Uh oh!

perlun commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcinil commented Mar 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

perlun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tarcinil Apr 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tarcinil Apr 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale bot commented Jun 8, 2018

Uh oh!

perlun commented Jun 20, 2018

Uh oh!

tarcinil commented Jun 20, 2018

Uh oh!

perlun commented Jun 21, 2018

Uh oh!

tarcinil commented Jun 21, 2018

Uh oh!

perlun commented Jun 22, 2018

Uh oh!

Uh oh!

tarcinil commented Mar 8, 2018 •

edited

Loading

perlun commented Mar 8, 2018 •

edited

Loading

tarcinil Apr 8, 2018 •

edited

Loading

tarcinil Apr 5, 2018 •

edited

Loading