Skip to content

removing unnecessary VERSION file #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2018
Merged

removing unnecessary VERSION file #379

merged 2 commits into from
Aug 1, 2018

Conversation

tarcinil
Copy link
Contributor

@tarcinil tarcinil commented Aug 1, 2018

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

removing un-needed file as we are now using Git::VERSION from inside the lib/git directory
fixes #376

@tarcinil
removing un-needed file as we are now using Git::VERSION from inside …
6c873a9 
…the lib/git

Signed-off-by: Vern Burton <me@vernburton.com>
@tarcinil tarcinil requested a review from perlun August 1, 2018 14:17
perlun
perlun approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing old cruft. 👍🏻

@tarcinil tarcinil merged commit 6d5bacd into ruby-git:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlun perlun perlun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VERSION file is not kept up to date with tag/version
2 participants
@tarcinil @perlun