Add unit testing for commit with option no-verify

Signed-off-by: Agora Security <github@agora-security.com>
ruby-git · AgoraSecurity · Aug 22, 2018 · Aug 24, 2018 · Oct 2, 2018 · Feb 17, 2019
commit 400ba63d83c2cdd1a4008fe7fd7c76ec346f2a39
diff --git a/tests/units/test_lib.rb b/tests/units/test_lib.rb
@@ -44,6 +44,37 @@ def test_commit_with_date
     assert_equal("Scott Chacon <schacon@gmail.com> #{author_date.strftime("%s %z")}", data['author'])
   end
 
+  def test_commit_with_no_verify
+    # Backup current pre-commit hook
+    pre_commit_path = "#{@wdir}/.git/hooks/pre-commit"
+    pre_commit_path_bak = "#{pre_commit_path}-bak"
+    move_file(pre_commit_path, pre_commit_path_bak)
+
+    # Adds a pre-commit file that should throw an error
+    create_file(pre_commit_path, 'echo Pre-commit file. Shoud not execute; exit 1') # Error when executed
+    File.chmod(0111, pre_commit_path)
+
+    create_file("#{@wdir}/test_file_2", 'content test_file_2')
+    @lib.add('test_file_2')
+
+    # Error raised because of pre-commit hook and no use of no_verify option
+    assert_raise Git::GitExecuteError do
+      @lib.commit('commit without no verify and pre-commit file')
+    end
+
+    # Error is not raised when no_verify is passed
+    assert_nothing_raised do
+      @lib.commit('commit with no verify and pre-commit file', no_verify: true )
+    end
+
+    # Restore pre-commit hook
+    move_file(pre_commit_path_bak, pre_commit_path)
+
+    # Verify the commit was created
+    data = @lib.commit_data('HEAD')
+    assert_equal("commit with no verify and pre-commit file\n", data['message'])
+  end
+
   def test_checkout
     assert(@lib.checkout('test_checkout_b',{:new_branch=>true}))
     assert(@lib.checkout('master'))