Skip to content

Add no verify for commit #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5033280
Adding ruby-head and ruby 2.6 to Travis, removing C ext from repo (#382)
tarcinil Aug 22, 2018
fff2dd8
Add support for unshallow (#377)
singpolyma Aug 24, 2018
6fc863b
Support merge-base (#370)
Oct 2, 2018
1c38db5
Do not allow changes to ENV to leak from test to test (#403)
jcouball Feb 17, 2019
123d259
Allow consumers to point git binary via env var (#416)
Sep 20, 2019
ea5cd9e
Add no verify for commit
AgoraSecurity Nov 7, 2019
84a271f
Implementation and tests required to ensure that command output encod…
jcouball Dec 11, 2019
3a5d962
Fix Stalebot settings to not auto-close old issues/PRs (#433)
perlun Jan 19, 2020
750e54a
Update version for pre-release (#435)
jcouball Jan 20, 2020
7a3123f
Include version.rb, providing Git::VERSION (#436)
cyclotron3k Jan 22, 2020
4cd8352
Removed blank after method name to fix warning (#439)
jcouball Jan 23, 2020
d44b476
Update instructions for making contributions (#438)
jcouball Jan 25, 2020
e74f79c
Add James Couball to the maintainers list. (#437)
jcouball Jan 25, 2020
a639f15
Release v1.6.0 (#443)
jcouball Feb 2, 2020
3abbdf9
Fix broken link in a PR template (#444)
yuta1024 Feb 3, 2020
05dbada
fix broken link in a PR template again (#446)
yuta1024 Feb 4, 2020
703b890
Fix describe command's dirty, abbrev, candidates, and match options (…
a4z Feb 6, 2020
6c0509a
Fix issue with color escape codes after recent update of `git` binari…
mhoyer Feb 10, 2020
186ee2c
Add yard doc for changes in #commit
AgoraSecurity Feb 21, 2020
a5e7acc
Add function to move files
AgoraSecurity Feb 21, 2020
400ba63
Add unit testing for commit with option no-verify
AgoraSecurity Feb 21, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add James Couball to the maintainers list. (#437)
Add instructions for releasing the git gem
Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
  • Loading branch information
jcouball authored and AgoraSecurity committed Feb 21, 2020
commit e74f79c87ed1d32ff0582d53a7ff712f120f87e8
5 changes: 3 additions & 2 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Maintainers

When making changes to the system, this file tells you who needs to review your patch - you need at least two maintainers to provide a :+1: on your pull request.
When making changes in this repository, one of the maintainers below must review and approve your pull request.

### Maintainers

* [Per Lundberg](https://github.com/perlun)
* [Vern Burton](https://github.com/tarcinil)
* [Vern Burton](https://github.com/tarcinil)
* [James Couball](https://github.com/jcouball)
57 changes: 57 additions & 0 deletions RELEASING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# How to release a new git.gem

Releasing a new version of the `git` gem requires these steps:
* [Prepare the release](#prepare-the-release)
* [Create a GitHub release](#create-a-github-release)
* [Build and release the gem](#build-and-release-the-gem)

These instructions use an example where the current release version is `1.5.0`
and the new release version to be created is `1.6.0.pre1`.

## Prepare the release

From a fork of ruby-git, create a PR containing changes to (1) bump the
version number, (2) update the CHANGELOG.md, and (3) tag the release.

* Bump the version number in lib/git/version.rb following [Semantic Versioning](https://semver.org)
guidelines
* Add a link in CHANGELOG.md to the release tag which will be created later
in this guide
* Create a new tag using [git-extras](https://github.com/tj/git-extras/blob/master/Commands.md#git-release)
`git release` command
* For example: `git release v1.6.0.pre1`
* These should be the only changes in the PR
* An example of these changes for `v1.6.0.pre1` can be found in [PR #435](https://github.com/ruby-git/ruby-git/pull/435)
* Get the PR reviewed, approved and merged to master.

## Create a GitHub release

On [the ruby-git releases page](https://github.com/ruby-git/ruby-git/releases),
select `Draft a new release`

* Select the tag corresponding to the version being released `v1.6.0.pre1`
* The Target should be `master`
* For the release description, use the output of [changelog-rs](https://github.com/perlun/changelog-rs)
* Since the release has not been created yet, you will need to supply
`changeling-rs` with the current release tag and the tag the new release
is being created from
* For example: `changelog-rs . v1.5.0 v1.6.0.pre1`
* Copy the output, omitting the tag header `## v1.6.0.pre1` and paste into
the release description
* The release description can be edited later if needed
* Select the appropriate value for `This is a pre-release`
* Since `v1.6.0.pre1` is a pre-release, check `This is a pre-release`

## Build and release the gem

Clone [ruby-git/ruby-git](https://github.com/ruby-git/ruby-git) directly (not a
fork) and ensure your local working copy is on the master branch

* Verify that you are not on a fork with the command `git remote -v`
* Verify that the version number is correct by running `rake -T` and inspecting
the output for the `release[remote]` task

Build the git gem and push it to rubygems.org with the command `rake release`

* Ensure that your `gem sources list` includes `https://rubygems.org` (in my
case, I usually have my work’s internal gem repository listed)