Skip to content

fix broken link in a PR template #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

yuta1024
Copy link
Contributor

@yuta1024 yuta1024 commented Feb 3, 2020

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

This PR fixes the broken link to CONTRIBUTING.md in a PR template.

@jcouball
Copy link
Member

jcouball commented Feb 3, 2020

Haha, was just about to open a PR for the same. I appreciate that you beat me to it.

I think that, although the same, this would be more concise:

[guidelines for contributing](CONTRIBUTING.md)

If you are willing to make that change and then squash the commit, I'll immediately approve this PR.

@jcouball
Copy link
Member

jcouball commented Feb 3, 2020

Further, I think you have to let the CI build run in order for ME to be able to merge this as the travis-ci build is a required check. I don't have permission to override this check.

Can you please remove the [ci skip] message from the commit and PR?

Signed-off-by: Yuta Harima <yuu725@gmail.com>
@yuta1024 yuta1024 changed the title [ci skip] fix broken link in a PR template fix broken link in a PR template Feb 3, 2020
Copy link
Member

@jcouball jcouball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution.

@jcouball jcouball merged commit e0a385f into ruby-git:master Feb 3, 2020
@yuta1024
Copy link
Contributor Author

yuta1024 commented Feb 3, 2020

Thank you for your quickly response!

@yuta1024 yuta1024 deleted the fix_broken_link branch February 3, 2020 18:32
@jcouball
Copy link
Member

jcouball commented Feb 3, 2020

@yuta1024 it ends up that our fix did not work when viewed in an actual PR.

It worked when viewing PULL_REQUEST_TEMPLATE.md from Github, but not from within an actual PR which is relative to https://guthub.com/ruby-git/ruby-git/pull/

The only thing that works in both contexts is an absolute link:
https://github.com/ruby-git/ruby-git/blob/master/CONTRIBUTING.md

See examples here:
#445

Do you want to do a new PR with the absolute URL or shall I?

@yuta1024
Copy link
Contributor Author

yuta1024 commented Feb 4, 2020

@jcouball Oh... I didn't confirm that the link works fine when viewed in a PR.
OK, I will fix to absolute link and send PR as soon as possible.

@yuta1024
Copy link
Contributor Author

yuta1024 commented Feb 4, 2020

I created PR #446 . Could you please confirm it?

AgoraSecurity pushed a commit to AgoraSecurity/ruby-git that referenced this pull request Feb 21, 2020
Signed-off-by: Yuta Harima <yuu725@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball jcouball mentioned this pull request Apr 19, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants