-
Notifications
You must be signed in to change notification settings - Fork 533
fix broken link in a PR template #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Haha, was just about to open a PR for the same. I appreciate that you beat me to it. I think that, although the same, this would be more concise:
If you are willing to make that change and then squash the commit, I'll immediately approve this PR. |
Further, I think you have to let the CI build run in order for ME to be able to merge this as the travis-ci build is a required check. I don't have permission to override this check. Can you please remove the [ci skip] message from the commit and PR? |
Signed-off-by: Yuta Harima <yuu725@gmail.com>
4488c82
to
195e1b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for the contribution.
Thank you for your quickly response! |
@yuta1024 it ends up that our fix did not work when viewed in an actual PR. It worked when viewing The only thing that works in both contexts is an absolute link: See examples here: Do you want to do a new PR with the absolute URL or shall I? |
@jcouball Oh... I didn't confirm that the link works fine when viewed in a PR. |
I created PR #446 . Could you please confirm it? |
Signed-off-by: Yuta Harima <yuu725@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
This PR fixes the broken link to
CONTRIBUTING.md
in a PR template.