Skip to content

Add no verify for commit with documentation #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2020

Conversation

AgoraSecurity
Copy link
Contributor

@AgoraSecurity AgoraSecurity commented Feb 21, 2020

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Add option to bypasses the pre-commit and commit-msg hooks

Improved PR of #426

Signed-off-by: Agora Security <github@agora-security.com>
Signed-off-by: Agora Security <github@agora-security.com>
Signed-off-by: Agora Security <github@agora-security.com>
In git commit, add:
       -n, --no-verify
           This option bypasses the pre-commit and commit-msg hooks. See also githooks(5).

Signed-off-by: Agora@Ubuntu-dev <filter@agora-security.com>
Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity AgoraSecurity mentioned this pull request Feb 21, 2020
3 tasks
@AgoraSecurity
Copy link
Contributor Author

@jcouball Documentation and unit testing has been added. This PR is related with #426

Please review and let me know if other changes are required.

# :no_verify
#
# @param [String] message the commit message to be used
# @param [Array] opts the commit options to be used

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YARD comes with support for annotating option hashes:

Suggested change
# @param [Array] opts the commit options to be used
# @param [Hash] opts the commit options to be used
# @option opts [Boolean] :amend
# @option opts [Boolean] :all
# @option opts [Boolean] :allow_empty
# @option opts [String] :author
# @option opts [String] :date
# @option opts [Boolean] :no_verify

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @olleolleolle but I am planning on adding proper yard docs across the board and will fix this then.

Copy link
Member

@jcouball jcouball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AgoraSecurity

@jcouball jcouball merged commit 861eb71 into ruby-git:master Apr 5, 2020
@pyrmont pyrmont mentioned this pull request Apr 14, 2020
3 tasks
@jcouball jcouball mentioned this pull request Apr 19, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants