-
Notifications
You must be signed in to change notification settings - Fork 533
Add no verify for commit with documentation #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no verify for commit with documentation #454
Conversation
Update master
Signed-off-by: Agora Security <github@agora-security.com>
Signed-off-by: Agora Security <github@agora-security.com>
Signed-off-by: Agora Security <github@agora-security.com>
In git commit, add: -n, --no-verify This option bypasses the pre-commit and commit-msg hooks. See also githooks(5). Signed-off-by: Agora@Ubuntu-dev <filter@agora-security.com> Signed-off-by: Agora Security <github@agora-security.com>
1ebf798
to
edd2c1f
Compare
# :no_verify | ||
# | ||
# @param [String] message the commit message to be used | ||
# @param [Array] opts the commit options to be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YARD comes with support for annotating option hashes:
# @param [Array] opts the commit options to be used | |
# @param [Hash] opts the commit options to be used | |
# @option opts [Boolean] :amend | |
# @option opts [Boolean] :all | |
# @option opts [Boolean] :allow_empty | |
# @option opts [String] :author | |
# @option opts [String] :date | |
# @option opts [Boolean] :no_verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @olleolleolle but I am planning on adding proper yard docs across the board and will fix this then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AgoraSecurity
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Add option to bypasses the pre-commit and commit-msg hooks
Improved PR of #426