Disable GPG Signing in Test Config #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has GPG signing set to true in their global .gitconfig file, the test suite will fail. This is because the test suit now includes a check of a commit message (the `test_commit_with_no_verify` test in `tests/units/test_lib.rb`) but did not update the test config file. This commit updates the config file to set the `gpgsign` option to false. Signed-off-by: Michael Camilleri <mike@inqk.net>
|
I tested this change and found that the test suite still fails if
$ git config --global --unset commit.gpgsign
$ git clone https://github.com/ruby-git/ruby-git.git ruby-git-gpgsign
...
$ cd ruby-git-gpgsign
$ bundle
...
$
$ bundle exec rake test
...
122 tests, 486 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
...
$
$ git config --global commit.gpgsign true
...
$
$ bundle exec rake test
...
122 tests, 356 assertions, 1 failures, 27 errors, 0 pendings, 0 omissions, 0 notifications
77.0492% passed
...
$
$ git fetch origin +refs/pull/467/merge
...
$ git checkout FETCH_HEAD
...
HEAD is now at e338a88 Merge 0c9cbcd9a8b352e44c4bf84bb483c6a19ee21233 into 861eb71e1c266606eefacf7ebd4bee4f34bee5de
$
$ cat tests/files/working/dot_git/config
[user]
name = Scott Chacon
email = schacon@gmail.com
[commit]
gpgsign = false
[core]
repositoryformatversion = 0
filemode = true
bare = false
logallrefupdates = true
[gui]
geometry = 986x682+365+124 211 500
[remote "working"]
url = ../working.git
fetch = +refs/heads/*:refs/remotes/working/*
$
$ bundle exec rake test
...
122 tests, 358 assertions, 0 failures, 26 errors, 0 pendings, 0 omissions, 0 notifications
78.6885% passed
...
$ |
|
@jcouball Thanks for the quick response. I'm not seeing the errors that you are seeing. My guess is that you're getting that result because you've enabled the That error goes away once I put the |
|
Ah, yes! Your guess was spot on. Once I set the # not a real signing key, of course :)
$ git config --global user.signingkey F2C7AB29
$ bundle exec rake test
...
122 tests, 486 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
...
$ |
jcouball
approved these changes
Apr 19, 2020
|
@jcouball That's great! Thanks for the merge! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Description
If a user has GPG signing set to true in their global
.gitconfigfile, the test suite will fail. This is because the test suit now includes a check of a commit message (thetest_commit_with_no_verifytest intests/units/test_lib.rbthat was added by #454) but did not update the test config file. This commit updates the config file to set thegpgsignoption to false.