Skip to content

Release v1.7.0 #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

Release v1.7.0 #468

merged 1 commit into from
Apr 25, 2020

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Apr 19, 2020 •
edited
Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Bump version and update CHANGELOG.md for 1.6.1 release.

v1.7.0

Full Changelog

@jcouball jcouball requested a review from perlun April 19, 2020 20:40
@perlun
Copy link
Contributor

perlun commented Apr 20, 2020

@jcouball Thanks for the effort. 👍 I have no problem with approving this, but I believe it would more rightfully be a v1.7.0 version, given that we are actually adding new functionality and not just bug fixes (#454 is an example of this). SemVer mandates that patch level updates (1.6.0 -> 1.6.1) should only be used for bug-fixes, and I believe this is an important rule to follow.

Would you be OK with this?

@jcouball jcouball changed the title Release v1.6.1 Release v1.7.0 Apr 20, 2020
@jcouball jcouball closed this Apr 20, 2020
@jcouball jcouball reopened this Apr 20, 2020
@jcouball
Release v1.7.0
65a2853 
Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball
Copy link
Member Author

Per, I have updated the version to 1.7.0 as requested. Can you approve when you have a moment?

@Kaspik
Copy link

Kaspik commented Apr 22, 2020

Looking forward for this release because of the Ruby 2.7 warnings!

@jcouball jcouball merged commit 2eb64a4 into ruby-git:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlun perlun perlun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcouball @perlun @Kaspik