Skip to content

Fix: entity instance methods exposure. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marshall-lee
Copy link
Member

Port of #164 to master.

This one fixes a regression introduced in ruby-grape#147: entity instance methods
were exposed with `NoMethodError`.
Fixes ruby-grape#163. Additional specs are added.
@marshall-lee marshall-lee force-pushed the fix_entity_private_methods_master branch from dc44ac1 to 5e38abc Compare August 3, 2015 17:17
marshall-lee added a commit that referenced this pull request Aug 3, 2015
…master

Fix: entity instance methods exposure.
@marshall-lee marshall-lee merged commit 62f6825 into ruby-grape:master Aug 3, 2015

another_friend = double('Friend', email: 'joe@example.com')
rep = EntitySpec::DelegatingEntity.new(another_friend)
expect(rep.value_for(:name)).to eq 'cooler name'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally deserves its own spec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants