-
Notifications
You must be signed in to change notification settings - Fork 27
Comparing changes
Open a pull request
base repository: rubyjs/libv8-node
base: node-21
head repository: rubyjs/libv8-node
compare: master
- 17 commits
- 13 files changed
- 3 contributors
Commits on Jul 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aae83f9 - Browse repository at this point
Copy the full SHA aae83f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb6f143 - Browse repository at this point
Copy the full SHA fb6f143View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7e17d2 - Browse repository at this point
Copy the full SHA e7e17d2View commit details
Commits on Aug 21, 2024
-
Disable use of Linux memory protection keys
V8's default thread-isolated allocator has a bug on x64 Linux. It uses memory protection keys (see `man 7 pkeys`) to write-protect JIT code memory but in a way that is currently incompatible with how we use threads. Specifically, pkey permissions are inherited by child threads. Threads that are not descendants of the thread that allocates the pkey default to "no permissions" for that pkey. Concretely, if thread A creates the v8::Platform (and the pkey) and write-protects memory, then later thread B tries to access that memory, it segfaults due to the lack of permissions. The fix on V8's side is conceptually easy - call pkey_set(PKEY_DISABLE_WRITE) before accessing the memory, to flip the permissions from "none" to "can read" - but until it's actually fixed, disable thread-isolation. Fixes: rubyjs/mini_racer#300 Refs: https://issues.chromium.org/issues/360909072
Configuration menu - View commit details
-
Copy full SHA for db82899 - Browse repository at this point
Copy the full SHA db82899View commit details
Commits on Aug 22, 2024
-
Merge pull request #53 from bnoordhuis/disable-pkey
Disable use of Linux memory protection keys
Configuration menu - View commit details
-
Copy full SHA for 0bfaa5d - Browse repository at this point
Copy the full SHA 0bfaa5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a616a9a - Browse repository at this point
Copy the full SHA a616a9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 362241d - Browse repository at this point
Copy the full SHA 362241dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8646501 - Browse repository at this point
Copy the full SHA 8646501View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3322d01 - Browse repository at this point
Copy the full SHA 3322d01View commit details -
attempt to upgrade CI so we only run on non EOL rubies.
2.7 and 3.0 are EOL
Configuration menu - View commit details
-
Copy full SHA for 9a0ad74 - Browse repository at this point
Copy the full SHA 9a0ad74View commit details -
Disable madvise(MADV_DONTFORK)
Node.js uses it to speed up fork & exec (stops V8 heap pages from getting copied into the forked process; slow) but mini_racer also supports fork & continue.
Configuration menu - View commit details
-
Copy full SHA for 7a1ee4b - Browse repository at this point
Copy the full SHA 7a1ee4bView commit details -
Merge pull request #54 from bnoordhuis/no-madv-dontfork
Disable madvise(MADV_DONTFORK)
Configuration menu - View commit details
-
Copy full SHA for 8dea2b8 - Browse repository at this point
Copy the full SHA 8dea2b8View commit details
Commits on Aug 26, 2024
-
Fix C++ tests, switch to C++17 (#55)
It was at C++14 but newer versions of V8 require C++17.
Configuration menu - View commit details
-
Copy full SHA for 1910d10 - Browse repository at this point
Copy the full SHA 1910d10View commit details
Commits on Aug 27, 2024
-
Note the V8 version didn't change between 22.6.0 and 22.7.0
Configuration menu - View commit details
-
Copy full SHA for b305a1e - Browse repository at this point
Copy the full SHA b305a1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62476a3 - Browse repository at this point
Copy the full SHA 62476a3View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc88262 - Browse repository at this point
Copy the full SHA fc88262View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8900cf6 - Browse repository at this point
Copy the full SHA 8900cf6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff node-21...master