Skip to content

Fix C++ tests, switch to C++17 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2024
Merged

Fix C++ tests, switch to C++17 #55

merged 3 commits into from
Aug 26, 2024

Conversation

bnoordhuis
Copy link
Collaborator

It was at C++14 but newer versions of V8 require C++17.

@bnoordhuis
Copy link
Collaborator Author

For posterity, the failing tests are:

   1) Failure:
MiniRacerTest#test_timeout [test/mini_racer_test.rb:1039]:
MiniRacer::ScriptTerminatedError expected but nothing was raised.

  2) Failure:
MiniRacerTest#test_estimated_size [test/mini_racer_test.rb:741]:
expecting the isolate to have values for all the vals

Interestingly, they pass locally for me but they fail consistently across the CI matrix.

They're not new failures though, so I'll go ahead and merge this, then investigate the failures.

@bnoordhuis bnoordhuis merged commit 1910d10 into rubyjs:node-22 Aug 26, 2024
8 of 24 checks passed
@bnoordhuis bnoordhuis deleted the fix-gtest branch August 26, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bnoordhuis