Skip to content

Fix C++ tests, switch to C++17 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Fix C++ tests, switch to C++17 #55

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6aaca6
Fix C++ tests, switch to C++17
bnoordhuis Aug 22, 2024
c0109f5
drop! run ci
bnoordhuis Aug 23, 2024
daf697a
squash! s/ShutdownPlatform/DisposePlatform/
bnoordhuis Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash! s/ShutdownPlatform/DisposePlatform/
  • Loading branch information
@bnoordhuis
bnoordhuis committed Aug 23, 2024
commit daf697ae73b78c98c31f2a80c1c7788ef9d3f1f4
4 changes: 2 additions & 2 deletions test/gtest/Framework.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct Framework {
main();

v8::V8::Dispose();
v8::V8::ShutdownPlatform();
v8::V8::DisposePlatform();
}

inline static void runWithIsolateRaw(iso_main main) {
Expand Down Expand Up @@ -50,4 +50,4 @@ struct Framework {
main(ctx);
});
}
};
};
Loading