Skip to content

Commit fbe7521

Browse files
fweisbecpaulmck
authored andcommitted
parisc: Add missing RCU idle APIs on idle loop
In the old times, the whole idle task was considered as an RCU quiescent state. But as RCU became more and more successful overtime, some RCU read side critical section have been added even in the code of some architectures idle tasks, for tracing for example. So nowadays, rcu_idle_enter() and rcu_idle_exit() must be called by the architecture to tell RCU about the part in the idle loop that doesn't make use of rcu read side critical sections, typically the part that puts the CPU in low power mode. This is necessary for RCU to find the quiescent states in idle in order to complete grace periods. Add this missing pair of calls in the parisc's idle loop. Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: James E.J. Bottomley <jejb@parisc-linux.org> Cc: Helge Deller <deller@gmx.de> Cc: Parisc <linux-parisc@vger.kernel.org> Cc: <stable@vger.kernel.org> # 3.3+ Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
1 parent 5b0753a commit fbe7521

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

arch/parisc/kernel/process.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
#include <linux/unistd.h>
4949
#include <linux/kallsyms.h>
5050
#include <linux/uaccess.h>
51+
#include <linux/rcupdate.h>
5152

5253
#include <asm/io.h>
5354
#include <asm/asm-offsets.h>
@@ -69,8 +70,10 @@ void cpu_idle(void)
6970

7071
/* endless idle loop with no priority at all */
7172
while (1) {
73+
rcu_idle_enter();
7274
while (!need_resched())
7375
barrier();
76+
rcu_idle_exit();
7477
schedule_preempt_disabled();
7578
check_pgt_cache();
7679
}

0 commit comments

Comments
 (0)