-
-
Notifications
You must be signed in to change notification settings - Fork 208
chore: upgrade yarn to v4 #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.yarn/install-state.gz
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still want Yarn V4? I ask this because I am using Yarn v4. I can make a PR to upgrade this or add a pr to add
"packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"
in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we want to have "packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"
in package.json?
Anyway, YES, we def. want to have yarn v4. If possible with a zero-install in ci 🥇 . I would appreciate it if you want to take care of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we can just work on this very branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we want to have
"packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"
in package.json?Anyway, YES, we def. want to have yarn v4. If possible with a zero-install in ci 🥇 . I would appreciate it if you want to take care of this
I asked that because I don't know if you guys want to use yarn v4 or wanna stick with yarn v1. I meant this PR have been here for a while. With "packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610", people with yarn V4 can at least work with this project without keep changing package.json back to the original one. (v4 will automatically add that line every time when I run yarn, kinda annoying 😄)
6caf4a3
to
2e5aa6e
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2e5aa6e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
wdyt @maxisam ? :) |
@hoebbelsB my gitignore is like
https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored I think yours would work as well. |
Thank you for making this work!!! |
No description provided.