Skip to content

chore: upgrade yarn to v4 #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore: upgrade yarn to v4 #1682

merged 1 commit into from
Sep 4, 2024

Conversation

edbzn
Copy link
Member

@edbzn edbzn commented Jan 25, 2024

No description provided.

@github-actions github-actions bot added </> Template @rx-angular/template related { } State @rx-angular/state related 📐 ESLint plugin 🛠️ CDK CDK related labels Jan 25, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still want Yarn V4? I ask this because I am using Yarn v4. I can make a PR to upgrade this or add a pr to add

"packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"

in package.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxisam

why would we want to have "packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610" in package.json?

Anyway, YES, we def. want to have yarn v4. If possible with a zero-install in ci 🥇 . I would appreciate it if you want to take care of this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we can just work on this very branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxisam

why would we want to have "packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610" in package.json?

Anyway, YES, we def. want to have yarn v4. If possible with a zero-install in ci 🥇 . I would appreciate it if you want to take care of this

I asked that because I don't know if you guys want to use yarn v4 or wanna stick with yarn v1. I meant this PR have been here for a while. With "packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610", people with yarn V4 can at least work with this project without keep changing package.json back to the original one. (v4 will automatically add that line every time when I run yarn, kinda annoying 😄)

Copy link

nx-cloud bot commented Sep 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2e5aa6e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@hoebbelsB
Copy link
Member

wdyt @maxisam ? :)

@maxisam
Copy link
Contributor

maxisam commented Sep 3, 2024

@hoebbelsB my gitignore is like

.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions

https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored

I think yours would work as well.

@hoebbelsB hoebbelsB merged commit 104dfac into main Sep 4, 2024
11 checks passed
@hoebbelsB hoebbelsB deleted the upgrade-yarn branch September 4, 2024 21:14
@maxisam
Copy link
Contributor

maxisam commented Sep 6, 2024

Thank you for making this work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ CDK CDK related 📐 ESLint plugin { } State @rx-angular/state related </> Template @rx-angular/template related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants