Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: scala-js/scala-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0fdaff5
Choose a base ref
...
head repository: scala-js/scala-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c7cbc7a
Choose a head ref
  • 13 commits
  • 175 files changed
  • 2 contributors

Commits on Jan 8, 2025

  1. Towards 1.18.2.

    sjrd committed Jan 8, 2025
    Configuration menu
    Copy the full SHA
    2cdb10b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2025

  1. Upgrade to Scala 2.12.20.

    sjrd committed Jan 12, 2025
    Configuration menu
    Copy the full SHA
    4f96d2c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff72b7f View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2025

  1. Fix #5115: Apply the StoreModule hack to JSConstructorDef from 1.8.

    Before 1.11, the body of `JSConstructorDef`s was a straight list of
    trees. We have a hack that extracts the three parts of a structured
    `JSConstructorBody`: `beforeSuper`, `superCall` and `afterSuper`.
    
    In 1.18, we introduced a separate hack to ensure that `afterSuper`
    starts with a `StoreModule` instruction.
    
    Unfortunately, we did not apply the latter hack on the result of
    the former. This means our deserializer incorrectly reads JS module
    classes from before 1.11.
    
    This commit makes sure to also apply the hack in that situation.
    
    Unfortunately, this does not come with automated tests. We do not
    have any non-native JS module class in our standard library, which
    is currently our only source of old IR for backward compatibility
    tests.
    sjrd committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    78ce1c8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #5113 from sjrd/scala-2.12.10-2.13.16

    Upgrade to Scala 2.12.20 and 2.13.16.
    gzm0 authored Jan 15, 2025
    Configuration menu
    Copy the full SHA
    8e69b34 View commit details
    Browse the repository at this point in the history
  3. Ensure the switch of Bug1955 is always a switch by adding more cases.

    Under 4 cases, some versions of the compiler do not emit a switch
    match. That defeats the purpose of that test.
    sjrd committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    7b5528e View commit details
    Browse the repository at this point in the history
  4. Fix #5112: Recognize asInstanceOf around jump to default label.

    That shape gets produced by Scala 2.13.16+ in some cases.
    sjrd committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    498e56b View commit details
    Browse the repository at this point in the history
  5. Codegen: Make the handling of default clause jumps more generic.

    Previously, we had to recognize specific shapes of case bodies in
    order to extract jumps to default labels. This was fragile, as
    changes in nsc's codegen could invalidate our assumptions.
    
    We now take a more general approach. We register the default label
    in the `enclosingLabelDefInfos`. Jumps to that label can therefore
    be handled wherever they appear inside the case bodies.
    
    We still require a specific shape to extract the *definition* of
    the default label in the wildcard case. This can't be helped, as
    far as I can tell.
    
    Ultimately, the JS code generated for the test suites is unchanged,
    both in 2.12 and 2.13.
    sjrd committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    ee3e9a0 View commit details
    Browse the repository at this point in the history
  6. Optimize the shapes of js.Dynamic.literal() in Scala 2.13.

    Somehow it had always escaped us that we did not correctly perform
    that optimization in Scala 2.13.
    sjrd committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    dac9aa7 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #5116 from sjrd/fix-jsmoduleclass-hack-aftersuper-…

    …from-1.8
    
    Fix #5115: Apply the StoreModule hack to JSConstructorDef from 1.8.
    sjrd authored Jan 15, 2025
    Configuration menu
    Copy the full SHA
    6203902 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2025

  1. Merge pull request #5114 from sjrd/fix-switch-match-guard-bug-2.13.16

    Fix #5112: Recognize asInstanceOf around jump to default label.
    sjrd authored Jan 16, 2025
    Configuration menu
    Copy the full SHA
    b8c3f06 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #5117 from sjrd/object-literal-on-2.13

    Optimize the shapes of `js.Dynamic.literal()` in Scala 2.13.
    sjrd authored Jan 16, 2025
    Configuration menu
    Copy the full SHA
    c5f5ab7 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2025

  1. Version 1.18.2.

    sjrd committed Jan 21, 2025
    2 Configuration menu
    Copy the full SHA
    c7cbc7a View commit details
    Browse the repository at this point in the history
Loading