Skip to content

DOC broken image link in user guide due to removal of example #30058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Charlie-XIAO opened this issue Oct 13, 2024 · 2 comments · Fixed by #30059
Closed

DOC broken image link in user guide due to removal of example #30058

Charlie-XIAO opened this issue Oct 13, 2024 · 2 comments · Fixed by #30059
Assignees
@glemaitre
Labels
Documentation

Comments

@Charlie-XIAO
Copy link
Contributor

Charlie-XIAO commented Oct 13, 2024 •
edited
Loading

Describe the issue linked to the documentation

The image at the bottom of Section 3.5.1 on https://scikit-learn.org/dev/modules/learning_curve.html is broken, which I believe is due to the removal of some example in #29936. We may want to rework or remove the last part.

Suggest a potential alternative/fix

NA
@Charlie-XIAO Charlie-XIAO added Documentation Needs Triage Issue requires triage labels Oct 13, 2024
@virchan
Copy link
Member

virchan commented Oct 13, 2024

I believe the broken link was intended to reference the following example:

https://scikit-learn.org/1.5/auto_examples/model_selection/plot_validation_curve.html

We can simply reintroduce it into the current example to maintain the logical flow.

Would it make sense to fix this by "reverting part of the example"? If not, I'd be happy to take on this issue.

CC: @glemaitre

@glemaitre
Copy link
Member

Yep I forgot to check the back reference to the example. I'll make a PR to solve the issue.

@glemaitre glemaitre removed the Needs Triage Issue requires triage label Oct 13, 2024
@glemaitre glemaitre self-assigned this Oct 13, 2024
@glemaitre glemaitre mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glemaitre glemaitre

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC fix back references to removed example glemaitre/scikit-learn
3 participants
@glemaitre @virchan @Charlie-XIAO