[MRG+1] add changelog entry for fixed and merged PR #10005 issue #9633 #10025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomDLT
reviewed
Oct 27, 2017
doc/whats_new/v0.20.rst
Outdated
| @@ -96,6 +96,10 @@ Classifiers and regressors | |||
| identical X values. | |||
| :issue:`9432` by :user:`Dallas Card <dallascard>` | |||
|
|
|||
| - Fixed a bug in :class:`naive_bayes.GaussianNB` which incorrectly raised | |||
| error for prior list which summed to 1. | |||
| :issue:`9633` by :user:`sschnug <sschnug>` | |||
There was a problem hiding this comment.
You can use your PR and your username here, since you fixed the bug.
:issue:`10005` by :user:`Gaurav Dhingra <gxyd>`
|
Do we have automatic cancellation of 'builds' in scikit-learn when a new commit is sent (for cancellation of 'builds' that are already running)? |
Depends on the CI and the actual settings we are using. Don't know off the top of my head the current status, but I would say:
Also friendly advice: issue numbers in title are generally not helpful, use a more helpful title that a human can understand, keep issue numbers for for the PR description, where it adds links and backreferences from the linked issue. |
|
Yes for CircleCi and AppVeyor |
donigian
added a commit
to donigian/scikit-learn
that referenced
this pull request
Oct 28, 2017
…cs/donigian-update-contribution-guidelines * 'master' of github.com:scikit-learn/scikit-learn: (23 commits) fixes scikit-learn#10031: fix attribute name and shape in documentation (scikit-learn#10033) [MRG+1] add changelog entry for fixed and merged PR scikit-learn#10005 issue scikit-learn#9633 (scikit-learn#10025) [MRG] Fix LogisticRegression see also should include LogisticRegressionCV(scikit-learn#9995) (scikit-learn#10022) [MRG + 1] Labels of clustering should start at 0 or -1 if noise (scikit-learn#10015) MAINT Remove redundancy in scikit-learn#9552 (scikit-learn#9573) [MRG+1] correct comparison in GaussianNB for 'priors' (scikit-learn#10005) [MRG + 1] ENH add check_inverse in FunctionTransformer (scikit-learn#9399) [MRG] FIX bug in nested set_params usage (scikit-learn#9999) [MRG+1] Fix LOF and Isolation benchmarks (scikit-learn#9798) [MRG + 1] Fix negative inputs checking in mean_squared_log_error (scikit-learn#9968) DOC Fix typo (scikit-learn#9996) DOC Fix typo: x axis -> y axis (scikit-learn#9985) improve example plot_forest_iris.py (scikit-learn#9989) [MRG+1] Deprecate pooling_func unused parameter in AgglomerativeClustering (scikit-learn#9875) DOC update news DOC Fix three typos in manifold documentation (scikit-learn#9990) DOC add missing dot in docstring DOC Add what's new for 0.19.1 (scikit-learn#9983) Improve readability of outlier detection example. (scikit-learn#9973) DOC: Fixed typo (scikit-learn#9977) ...
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…issue scikit-learn#9633 (scikit-learn#10025) * add changelog entry for fixed and merged PR scikit-learn#10005 issue scikit-learn#9633 * change name * change PR number
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…issue scikit-learn#9633 (scikit-learn#10025) * add changelog entry for fixed and merged PR scikit-learn#10005 issue scikit-learn#9633 * change name * change PR number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See this comment #10005 (comment)
What does this implement/fix? Explain your changes.
added a change log entry for issue #9633
Any other comments?