Skip to content

Improve warning reporting in LARS test #12597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2019

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 15, 2018

This should improve the error message for the failures reported on the Debian AMD64 continuous integration (see #12548).

@ogrisel ogrisel requested a review from yarikoptic November 15, 2018 15:37
@ogrisel
Copy link
Member Author

ogrisel commented Nov 15, 2018

@yarikoptic it would be great if you could trigger a run on the failing machine with this code to better understand the source of the problem.

@ogrisel
Copy link
Member Author

ogrisel commented May 20, 2019

The windows failure is unrelated.

@jnothman @rth @thomasjpfan what do you think about merging this one? I would like to have more informative error message next time we encounter this pbm.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jnothman jnothman merged commit 0a2dc72 into scikit-learn:master May 20, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request May 21, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@ogrisel ogrisel deleted the lars-better-warnings branch December 8, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants