Skip to content

MNT Don't persist doc in doc-min-dependencies job #12782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

MNT Don't persist doc in doc-min-dependencies job #12782

merged 1 commit into from
Dec 14, 2018

Conversation

qinhanmin2014
Copy link
Member

Correct mistakes in #12746
ping @adrinjalali @rth @ogrisel

@adrinjalali
Copy link
Member

LGTM, but I'm not sure if this is related to the error we see on master.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if this is related to the error we see on master.

Same here, it's an improvement either way.

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinjalali
Copy link
Member

Also, I suppose the pull request branches don't actually get deployed:

if [[ "${CIRCLE_BRANCH}" =~ ^master$|^[0-9]+\.[0-9]+\.X$ ]]; then

We kinda need to test it on master.

@qinhanmin2014
Copy link
Member Author

Also, I suppose the pull request branches don't actually get deployed

Yes, we cannot deploy PR

@qinhanmin2014 qinhanmin2014 merged commit 3cb4a52 into scikit-learn:master Dec 14, 2018
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Dec 14, 2018
@qinhanmin2014
Copy link
Member Author

Hmm, @adrinjalali what did you do? Seems that you add a new deploy key?
https://github.com/scikit-learn/scikit-learn/settings/keys

@qinhanmin2014 qinhanmin2014 deleted the circle-ci-hot-fix branch December 15, 2018 02:20
@adrinjalali
Copy link
Member

I suppose the exact thing which happened in #11550 may have happened here. I only wanted to have sklearn in my dashboard in circle-ci and watch the jobs. I have no idea why that key was added, and have no idea why that affects the github.io repo at all. I removed that key, and see if it works now.

@adrinjalali
Copy link
Member

Yep, it was the same issue. Removing the recent read-only deploy key from the sklearn repo had it fixed. It is really counterintuitive!

@qinhanmin2014
Copy link
Member Author

Yep, it was the same issue. Removing the recent read-only deploy key from the sklearn repo had it fixed. It is really counterintuitive!

Thanks @adrinjalali :)

adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Jan 7, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants