-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT Don't persist doc in doc-min-dependencies job #12782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Don't persist doc in doc-min-dependencies job #12782
Conversation
LGTM, but I'm not sure if this is related to the error we see on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not sure if this is related to the error we see on master.
Same here, it's an improvement either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also, I suppose the pull request branches don't actually get deployed:
We kinda need to test it on master. |
Yes, we cannot deploy PR |
Hmm, @adrinjalali what did you do? Seems that you add a new deploy key? |
I suppose the exact thing which happened in #11550 may have happened here. I only wanted to have sklearn in my dashboard in circle-ci and watch the jobs. I have no idea why that key was added, and have no idea why that affects the github.io repo at all. I removed that key, and see if it works now. |
Yep, it was the same issue. Removing the recent read-only deploy key from the sklearn repo had it fixed. It is really counterintuitive! |
Thanks @adrinjalali :) |
Correct mistakes in #12746
ping @adrinjalali @rth @ogrisel