-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] DOC Resolve a missing link on the home page #12847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] DOC Resolve a missing link on the home page #12847
Conversation
Thanks @akahard2dj . I think the goal of the issue is not to put the example back, since it was removed and moved around in #10700, but to change and fix the links on the homepage. You can see how the examples have been moved on the original PR, and fix the links accordingly. |
@adrinjalali Thanks for your valuable comment. |
The example replacing You need to change both line 256 in doc/conf.py carousel_thumbs = {'sphx_glr_plot_classifier_comparison_001.png': 600,
'sphx_glr_plot_outlier_detection_003.png': 372,
'sphx_glr_plot_gpr_co2_001.png': 350,
'sphx_glr_plot_adaboost_twoclass_001.png': 372,
'sphx_glr_plot_compare_methods_001.png': 349} and lines 152-153 in doc/themes/scikit-learn/layout.html <div class="item">
<a href="{{pathto('auto_examples/covariance/plot_outlier_detection') }}">
<img src="_images/sphx_glr_plot_outlier_detection_003_carousel.png"></a>
</div>
|
@albertcthomas Really thanks. This commit is entirely based on @albertcthomas 's comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example to use is plot_anomaly_comparison
, not plot_lof_novelty_detection
doc/conf.py
Outdated
@@ -253,7 +253,7 @@ | |||
# key: first image in set | |||
# values: (number of plot in set, height of thumbnail) | |||
carousel_thumbs = {'sphx_glr_plot_classifier_comparison_001.png': 600, | |||
'sphx_glr_plot_outlier_detection_003.png': 372, | |||
'sphx_glr_plot_lof_novelty_detection_001.png': 372, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the example to use is plot_anomaly_comparison
, not plot_lof_novelty_detection
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I change the example case from novelty detection to anomaly comparison.
Thanks. Happy Christmas.
doc/themes/scikit-learn/layout.html
Outdated
@@ -149,8 +149,8 @@ | |||
style="max-height: 200px; max-width: 629px; margin-left: -21px;"></div></a> | |||
</div> | |||
<div class="item"> | |||
<a href="{{pathto('auto_examples/covariance/plot_outlier_detection') }}"> | |||
<img src="_images/sphx_glr_plot_outlier_detection_003_carousel.png"></a> | |||
<a href="{{pathto('auto_examples/neighbors/plot_lof_novelty_detection') }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same commit as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akahard2dj. Also I don't know if there is a way to view how the changes render.
doc/themes/scikit-learn/layout.html
Outdated
<a href="{{pathto('auto_examples/covariance/plot_outlier_detection') }}"> | ||
<img src="_images/sphx_glr_plot_outlier_detection_003_carousel.png"></a> | ||
<a href="{{pathto('auto_examples/plot_anomaly_comparison') }}"> | ||
<img src="_images/sphx_glr_plot_anomaly_comparison_001.png"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_carousel
or _thumb
missing at the end of the name. I don't really know the difference...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.. I will fix that.
Actually website works good. but the image size is too big. I will change a thumb image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @akahard2dj
restarted Circle, will merge when green. |
…)" This reverts commit c763dc2.
…)" This reverts commit c763dc2.
closes #12837
In my scope, this action is seems to resolve the issue.
If this action is not correct, please comment.