Skip to content

[MRG] DOC Resolve a missing link on the home page #12847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 27, 2018
Merged

[MRG] DOC Resolve a missing link on the home page #12847

merged 9 commits into from
Dec 27, 2018

Conversation

akahard2dj
Copy link
Contributor

closes #12837

In my scope, this action is seems to resolve the issue.
If this action is not correct, please comment.

@adrinjalali
Copy link
Member

Thanks @akahard2dj . I think the goal of the issue is not to put the example back, since it was removed and moved around in #10700, but to change and fix the links on the homepage. You can see how the examples have been moved on the original PR, and fix the links accordingly.

@akahard2dj
Copy link
Contributor Author

@adrinjalali Thanks for your valuable comment.
I will check #10700.

@albertcthomas
Copy link
Contributor

The example replacing examples/covariance/plot_outlier_detection.py is examples/plot_anomaly_comparison.py.

You need to change both line 256 in doc/conf.py

carousel_thumbs = {'sphx_glr_plot_classifier_comparison_001.png': 600,
                   'sphx_glr_plot_outlier_detection_003.png': 372,
                   'sphx_glr_plot_gpr_co2_001.png': 350,
                   'sphx_glr_plot_adaboost_twoclass_001.png': 372,
                   'sphx_glr_plot_compare_methods_001.png': 349}

and lines 152-153 in doc/themes/scikit-learn/layout.html

<div class="item">
  <a href="{{pathto('auto_examples/covariance/plot_outlier_detection') }}">
    <img src="_images/sphx_glr_plot_outlier_detection_003_carousel.png"></a>
</div>

003 in the filename should be replaced by 001.

@akahard2dj
Copy link
Contributor Author

@albertcthomas Really thanks. This commit is entirely based on @albertcthomas 's comment.
plot_outlier_detection example is changed to novelty_detection.
So I also fixed that previous thumbs image of sphx_glr_plot_outlier_detection_00x.png to sphx_glr_plot_lof_novelty_detection_001.png.

Copy link
Contributor

@albertcthomas albertcthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example to use is plot_anomaly_comparison, not plot_lof_novelty_detection

doc/conf.py Outdated
@@ -253,7 +253,7 @@
# key: first image in set
# values: (number of plot in set, height of thumbnail)
carousel_thumbs = {'sphx_glr_plot_classifier_comparison_001.png': 600,
'sphx_glr_plot_outlier_detection_003.png': 372,
'sphx_glr_plot_lof_novelty_detection_001.png': 372,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the example to use is plot_anomaly_comparison, not plot_lof_novelty_detection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I change the example case from novelty detection to anomaly comparison.
Thanks. Happy Christmas.

@@ -149,8 +149,8 @@
style="max-height: 200px; max-width: 629px; margin-left: -21px;"></div></a>
</div>
<div class="item">
<a href="{{pathto('auto_examples/covariance/plot_outlier_detection') }}">
<img src="_images/sphx_glr_plot_outlier_detection_003_carousel.png"></a>
<a href="{{pathto('auto_examples/neighbors/plot_lof_novelty_detection') }}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same commit as above

Copy link
Contributor

@albertcthomas albertcthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akahard2dj. Also I don't know if there is a way to view how the changes render.

<a href="{{pathto('auto_examples/covariance/plot_outlier_detection') }}">
<img src="_images/sphx_glr_plot_outlier_detection_003_carousel.png"></a>
<a href="{{pathto('auto_examples/plot_anomaly_comparison') }}">
<img src="_images/sphx_glr_plot_anomaly_comparison_001.png"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_carousel or _thumb missing at the end of the name. I don't really know the difference...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. I will fix that.
Actually website works good. but the image size is too big. I will change a thumb image.

@akahard2dj
Copy link
Contributor Author

screenshot from 2018-12-27 02-50-33
I upload a render image.
In my option, all requests is fixed.
Please review the final draft.

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @akahard2dj

@qinhanmin2014
Copy link
Member

restarted Circle, will merge when green.

@qinhanmin2014 qinhanmin2014 changed the title [MRG] add a example file to resolve a missing link [MRG] DOC Resolve a missing link on the home page Dec 27, 2018
@qinhanmin2014 qinhanmin2014 merged commit 3cb31de into scikit-learn:master Dec 27, 2018
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Jan 7, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Feb 19, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage links to moved example
4 participants