Skip to content

[MRG] Configure lgtm.yml for CPP #13044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 26, 2019
Merged

[MRG] Configure lgtm.yml for CPP #13044

merged 15 commits into from
Jan 26, 2019

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Jan 24, 2019 •
edited
Loading

Fixes LGTM by using python 3 to build scikit-learn when going through C/C++ extraction.

@thomasjpfan thomasjpfan mentioned this pull request Jan 25, 2019
Merged
@thomasjpfan thomasjpfan changed the title [WIP] Configure lgtm.yml for CPP [MRG] Configure lgtm.yml for CPP Jan 25, 2019
@s0
Copy link

s0 commented Jan 25, 2019 •
edited
Loading

FTR, this is the config file we wrote internally and applied to get the C++ analysis working:

extraction:
  cpp:
    prepare:
      packages:
        - python3-numpy
        - python3-scipy
        - cython3
    after_prepare:
      # Build works fine with Ubuntu 18.04's cython version 0.26.1
      - sed -i "s/0.28.5/0.26.1/" sklearn/_build_utils/__init__.py
    index:
      build_command:
        - python3 setup.py build

@s0 s0 mentioned this pull request Jan 25, 2019
Closed
@s0
Copy link

s0 commented Jan 25, 2019 •
edited
Loading

The one you've written though seems to also work, and is a lot cleaner, so this PR LGTM if squashed :)

@glemaitre glemaitre self-requested a review January 26, 2019 10:04
glemaitre
glemaitre approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit e8045a7 into scikit-learn:master Jan 26, 2019
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 30, 2019
@thomasjpfan @glemaitre
[MRG] Configure lgtm.yml for CPP (scikit-learn#13044)
ec0ab84
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 7, 2019
@thomasjpfan
[MRG] Configure lgtm.yml for CPP (scikit-learn#13044)
eadc983
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@thomasjpfan
[MRG] Configure lgtm.yml for CPP (scikit-learn#13044)
1cc6736
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "[MRG] Configure lgtm.yml for CPP (scikit-learn#13044)"
170072a 
This reverts commit 1cc6736.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "[MRG] Configure lgtm.yml for CPP (scikit-learn#13044)"
b3e079a 
This reverts commit 1cc6736.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@thomasjpfan @koenvandevelde
[MRG] Configure lgtm.yml for CPP (scikit-learn#13044)
2dec47f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @s0 @glemaitre